]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
jbd2: Drop pointless wakeup from jbd2_journal_stop()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2019 16:44:22 +0000 (17:44 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 5 Nov 2019 21:00:48 +0000 (16:00 -0500)
commit5559b2d81b51de75cb7864bb1fbb82982f7e8fff
tree2784d50f7c9f9fed46f5247b887b6de4567070cd
parent150549ed2fcf4be9bf3efedd99b72924dff26166
jbd2: Drop pointless wakeup from jbd2_journal_stop()

When we drop last handle from a transaction and journal->j_barrier_count
> 0, jbd2_journal_stop() wakes up journal->j_wait_transaction_locked
wait queue. This looks pointless - wait for outstanding handles always
happens on journal->j_wait_updates waitqueue.
journal->j_wait_transaction_locked is used to wait for transaction state
changes and by start_this_handle() for waiting until
journal->j_barrier_count drops to 0. The first case is clearly
irrelevant here since only jbd2 thread changes transaction state. The
second case looks related but jbd2_journal_unlock_updates() is
responsible for the wakeup in this case. So just drop the wakeup.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-16-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/transaction.c