]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles
authorSteven Noonan <steven@uplinklabs.net>
Sat, 25 Oct 2014 22:09:42 +0000 (15:09 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 Oct 2014 10:03:40 +0000 (11:03 +0100)
commit5631b8fba640a4ab2f8a954f63a603fa34eda96b
treeae2e0de1122e521522f2dee01a4a4d28566cd40b
parentcac7f2429872d3733dc3f9915857b1691da2eb2f
compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles

The bug referenced by the comment in this commit was not
completely fixed in GCC 4.8.2, as I mentioned in a thread back
in February:

   https://lkml.org/lkml/2014/2/12/797

The conclusion at that time was to make the quirk unconditional
until the bug could be found and fixed in GCC. Unfortunately,
when I submitted the patch (commit a9f18034) I left a comment
in that claimed the bug was fixed in GCC 4.8.2+.

This comment is inaccurate, and should be removed.

Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1414274982-14040-1-git-send-email-steven@uplinklabs.net
Cc: Ingo Molnar <mingo@kernel.org>
include/linux/compiler-gcc4.h
include/linux/compiler-gcc5.h