]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
phy: qcom-snps-femto-v2: properly enable ref clock
authorAdrien Thierry <athierry@redhat.com>
Thu, 29 Jun 2023 14:45:39 +0000 (10:45 -0400)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:20:47 +0000 (17:20 +0200)
commit56a3be4713564399b50b3fbf97988491d409a5f3
tree7926fa347f28fd6c45abb37e9c9fbfa378bdbfd2
parent2cb4175f2946caad7d012f31dff422c4c6e96c9b
phy: qcom-snps-femto-v2: properly enable ref clock

BugLink: https://bugs.launchpad.net/bugs/2037005
[ Upstream commit 8a0eb8f9b9a002291a3934acfd913660b905249e ]

The driver is not enabling the ref clock, which thus gets disabled by
the clk_disable_unused() initcall. This leads to the dwc3 controller
failing to initialize if probed after clk_disable_unused() is called,
for instance when the driver is built as a module.

To fix this, switch to the clk_bulk API to handle both cfg_ahb and ref
clocks at the proper places.

Note that the cfg_ahb clock is currently not used by any device tree
instantiation of the PHY. Work needs to be done separately to fix this.

Link: https://lore.kernel.org/linux-arm-msm/ZEqvy+khHeTkC2hf@fedora/
Fixes: 51e8114f80d0 ("phy: qcom-snps: Add SNPS USB PHY driver for QCOM based SOCs")
Signed-off-by: Adrien Thierry <athierry@redhat.com>
Link: https://lore.kernel.org/r/20230629144542.14906-3-athierry@redhat.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c