]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
mlx4: Avoid leaking steering rules on flow creation error flow
authorOr Gerlitz <ogerlitz@mellanox.com>
Thu, 30 Oct 2014 13:59:28 +0000 (15:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Oct 2014 23:48:58 +0000 (19:48 -0400)
commit571e1b2c7a4c2fd5faa1648462a6b65fa26530d7
treed82bbe2467a939416ef1e8726e4305ad9e7aad4d
parenta4f2dacbf2a5045e34b98a35d9a3857800f25a7b
mlx4: Avoid leaking steering rules on flow creation error flow

If mlx4_ib_create_flow() attempts to create > 1 rules with the
firmware, and one of these registrations fail, we leaked the
already created flow rules.

One example of the leak is when the registration of the VXLAN ghost
steering rule fails, we didn't unregister the original rule requested
by the user, introduced in commit d2fce8a9060d "mlx4: Set
user-space raw Ethernet QPs to properly handle VXLAN traffic".

While here, add dump of the VXLAN portion of steering rules
so it can actually be seen when flow creation fails.

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/infiniband/hw/mlx4/main.c
drivers/net/ethernet/mellanox/mlx4/mcg.c