]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
selftests: net: return Kselftest Skip code for skipped tests
authorShuah Khan (Samsung OSG) <shuah@kernel.org>
Fri, 4 May 2018 22:34:09 +0000 (16:34 -0600)
committerShuah Khan (Samsung OSG) <shuah@kernel.org>
Wed, 30 May 2018 21:29:06 +0000 (15:29 -0600)
commit57aefc7c226dae84e2724fc0229d85870a70ad24
treed98d004db54863994417300f4a637fbb6cca0f37
parente6ee6ae4a170335d685571f38510505dd62cc6a4
selftests: net: return Kselftest Skip code for skipped tests

When net test is skipped because of unmet dependencies and/or unsupported
configuration, it returns 0 which is treated as a pass by the Kselftest
framework. This leads to false positive result even when the test could
not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.

Change psock_tpacket to use ksft_exit_skip() when a non-root user runs
the test and add an explicit check for root and a clear message, instead
of failing the test when /sys/power/state file open fails.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
tools/testing/selftests/net/fib_tests.sh
tools/testing/selftests/net/netdevice.sh
tools/testing/selftests/net/pmtu.sh
tools/testing/selftests/net/psock_tpacket.c
tools/testing/selftests/net/rtnetlink.sh