]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: ks8851-ml: Fix 16-bit IO operation
authorMarek Vasut <marex@denx.de>
Sat, 15 Feb 2020 16:54:19 +0000 (17:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Feb 2020 03:41:09 +0000 (19:41 -0800)
commit58292104832fef6cb4a89f736012c0e0724c3442
treee2bd60984186b7de05da2d449702c122f0b04449
parentedacb098ea9c31589276152f09b4439052c0f2b1
net: ks8851-ml: Fix 16-bit IO operation

The Micrel KSZ8851-16MLLI datasheet DS00002357B page 12 states that
BE[3:0] signals are active high. This contradicts the measurements
of the behavior of the actual chip, where these signals behave as
active low. For example, to read the CIDER register, the bus must
expose 0xc0c0 during the address phase, which means BE[3:0]=4'b1100.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ks8851_mll.c