]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/i915/icl: use tc_port in MG_PLL macros
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 25 Jan 2019 22:24:41 +0000 (14:24 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Tue, 29 Jan 2019 22:35:02 +0000 (14:35 -0800)
commit584fca111d0cf32f6002472d9cb13c4555587438
tree908f8471e76b505f274dd02a1a56e919b2cefd76
parent789659f4307abc1c2356db09eeefefd3f445c12d
drm/i915/icl: use tc_port in MG_PLL macros

Fix the TODO leftover in the code by changing the argument in MG_PLL
macros. The MG_PLL ids used to access the register values can be
converted from tc_port rather than port.

All these registers can use the TC port to calculate the right offsets
because they are only available for TC ports. The range (PORT_C onwards)
may not be stable and change from platform to platform. So by using the
TC id directly we avoid having to check for the platform in the "leaf
functions" and thus passing dev_priv around.

The helper functions were also renamed to use "tc" as prefix to make
them more generic.

v2: Improve commit message and fix checkpatch warning (from Paulo)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125222444.19926-2-lucas.demarchi@intel.com
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_ddi.c
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_dpll_mgr.c
drivers/gpu/drm/i915/intel_dpll_mgr.h