]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
blk-mq: I/O and timer unplugs are inverted in blktrace
authorIlya Dryomov <idryomov@gmail.com>
Wed, 26 Sep 2018 12:35:50 +0000 (14:35 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 27 Sep 2018 19:12:44 +0000 (13:12 -0600)
commit587562d0c7cd6861f4f90a2eb811cccb1a376f5f
treeb9ee430b0d44ed832f341b35fceca990a29d9496
parent0f843e65d9eef4936929bb036c5f771fb261eea4
blk-mq: I/O and timer unplugs are inverted in blktrace

trace_block_unplug() takes true for explicit unplugs and false for
implicit unplugs.  schedule() unplugs are implicit and should be
reported as timer unplugs.  While correct in the legacy code, this has
been inverted in blk-mq since 4.11.

Cc: stable@vger.kernel.org
Fixes: bd166ef183c2 ("blk-mq-sched: add framework for MQ capable IO schedulers")
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c