]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
min/max: remove sparse warnings when they're nested
authorJohannes Berg <johannes.berg@intel.com>
Sat, 8 Oct 2016 00:02:42 +0000 (17:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 8 Oct 2016 01:46:30 +0000 (18:46 -0700)
commit589a9785ee3a7cb85f1dedc3dad1c9754c691880
tree2a58cb3d8c4c0e1c9e025750dd4801f99352d7f1
parent53aeee7a86620b4dca81f6b807b37f36e7f99b09
min/max: remove sparse warnings when they're nested

Currently, when min/max are nested within themselves, sparse will warn:

    warning: symbol '_min1' shadows an earlier one
    originally declared here
    warning: symbol '_min1' shadows an earlier one
    originally declared here
    warning: symbol '_min2' shadows an earlier one
    originally declared here

This also immediately happens when min3() or max3() are used.

Since sparse implements __COUNTER__, we can use __UNIQUE_ID() to
generate unique variable names, avoiding this.

Link: http://lkml.kernel.org/r/1471519773-29882-1-git-send-email-johannes@sipsolutions.net
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/kernel.h