]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
PCI/ASPM: Clear the correct bits when enabling L1 substates
authorYicong Yang <yangyicong@hisilicon.com>
Fri, 13 Mar 2020 09:53:47 +0000 (17:53 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 18 Mar 2020 22:43:14 +0000 (17:43 -0500)
commit58a3862a10a317a81097ab0c78aecebabb1704f5
treeb324cdaf0a1b4aeee268fb6d0ab6fc5f431ec5da
parentbb6d3fb354c5ee8d6bde2d576eb7220ea09862b9
PCI/ASPM: Clear the correct bits when enabling L1 substates

In pcie_config_aspm_l1ss(), we cleared the wrong bits when enabling ASPM L1
Substates.  Instead of the L1.x enable bits (PCI_L1SS_CTL1_L1SS_MASK, 0xf), we
cleared the Link Activation Interrupt Enable bit (PCI_L1SS_CAP_L1_PM_SS,
0x10).

Clear the L1.x enable bits before writing the new L1.x configuration.

[bhelgaas: changelog]
Fixes: aeda9adebab8 ("PCI/ASPM: Configure L1 substate settings")
Link: https://lore.kernel.org/r/1584093227-1292-1-git-send-email-yangyicong@hisilicon.com
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org # v4.11+
drivers/pci/pcie/aspm.c