]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
crypto: crct10dif-generic - fix use via crypto_shash_digest()
authorEric Biggers <ebiggers@google.com>
Sun, 31 Mar 2019 20:04:12 +0000 (13:04 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 30 Jul 2019 10:58:17 +0000 (12:58 +0200)
commit58ee7ac1653da91ece49d9682cbeb824d2245253
treeb8485076f6f27c6e10331f59b850af8bfcefa8f5
parent42cc9a64aebc7823b984378a273dba6ecd98cfcb
crypto: crct10dif-generic - fix use via crypto_shash_digest()

BugLink: https://bugs.launchpad.net/bugs/1836614
commit 307508d1072979f4435416f87936f87eaeb82054 upstream.

The ->digest() method of crct10dif-generic reads the current CRC value
from the shash_desc context.  But this value is uninitialized, causing
crypto_shash_digest() to compute the wrong result.  Fix it.

Probably this wasn't noticed before because lib/crc-t10dif.c only uses
crypto_shash_update(), not crypto_shash_digest().  Likewise,
crypto_shash_digest() is not yet tested by the crypto self-tests because
those only test the ahash API which only uses shash init/update/final.

This bug was detected by my patches that improve testmgr to fuzz
algorithms against their generic implementation.

Fixes: 2d31e518a428 ("crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework")
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
crypto/crct10dif_generic.c