]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
firmware: arm_scmi: Fix range check for the maximum number of pending messages
authorCristian Marussi <cristian.marussi@arm.com>
Mon, 12 Jul 2021 14:18:18 +0000 (15:18 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 20 Sep 2021 13:42:12 +0000 (15:42 +0200)
commit58fe17abae20bbcd45ad0d6240fcc9ec66e79a3e
tree08123eedb9e51fb2ab658fd5f700a1a7bb684a77
parente20e1874a28784a58338f6ed48833bacdd5492ce
firmware: arm_scmi: Fix range check for the maximum number of pending messages

BugLink: https://bugs.launchpad.net/bugs/1940706
[ Upstream commit bdb8742dc6f7c599c3d61959234fe4c23638727b ]

SCMI message headers carry a sequence number and such field is sized to
allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an
acceptable maximum number of pending in-flight messages.

Fix accordingly the checks performed on the value exported by transports
in scmi_desc.max_msg

Link: https://lore.kernel.org/r/20210712141833.6628-3-cristian.marussi@arm.com
Reported-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
[sudeep.holla: updated the patch title and error message]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/firmware/arm_scmi/driver.c