]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
authorColin Ian King <colin.king@canonical.com>
Mon, 5 Jun 2017 09:04:52 +0000 (10:04 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Jun 2017 19:13:46 +0000 (15:13 -0400)
commit594238158bf748c285f0a73222cd9b7ccf3c525d
tree0fc2e20e8b26f80277c1914f929e5e3ee63746e9
parent7b868fed00f6c72d3e0270bcb057b4f26c09e809
net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

The current comparison of entry < 0 will never be true since entry is an
unsigned integer. Make entry an int to ensure -ve error return values
from the call to jumbo_frm are correctly being caught.

Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c