]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
perf hists browser: Check sort keys before hot key actions
authorNamhyung Kim <namhyung@kernel.org>
Wed, 9 Mar 2016 14:20:53 +0000 (23:20 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 10 Mar 2016 19:48:02 +0000 (16:48 -0300)
commit599a2f38a989a79df99838f22cb607f5e2b5b56c
treea278dc8a4e26b709746e0f287f0f082ebff148b1
parent6962ccb37b50366014074aec6fd14497cf719642
perf hists browser: Check sort keys before hot key actions

The context menu in TUI hists browser checks corresponding sort keys
when creating the menu item.  But hotkey actions lacks these checks so
it can filter using incorrect info.

For example, default sort key of 'perf top' doesn't contain 'comm' or
'pid' sort key so each hist entry's thread info is not reliable.  Thus
it should prohibit using thread filter on 't' key.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1457533253-21419-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c