]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Mon, 20 Jan 2020 16:01:17 +0000 (18:01 +0200)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 24 Feb 2020 15:20:03 +0000 (16:20 +0100)
commit59ee70ab85447d43ace17ed180bb5880ad7f9c6b
tree67e07fa6b824bbad955b255288f517659231421b
parent4b79a87d6923cad210ff289c1071d186fafbdbc2
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()

BugLink: https://bugs.launchpad.net/bugs/1864488
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: https://github.com/thesofproject/linux/issues/1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
sound/pci/hda/patch_hdmi.c