]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
batman-adv: Fix own OGM check in aggregated OGMs
authorLinus Lüssing <linus.luessing@c0d3.blue>
Thu, 23 Jul 2020 12:28:08 +0000 (14:28 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Thu, 17 Sep 2020 06:47:03 +0000 (00:47 -0600)
commit5a2ec80a386d39b125130e18a14b6feb6bcc5e0c
tree065d0c28ade0199cf9b50c73aeff092ea7e338b5
parent62e7c42eedf9a1d0129bc290367f8cdbfe1b4d2b
batman-adv: Fix own OGM check in aggregated OGMs

BugLink: https://bugs.launchpad.net/bugs/1895880
[ Upstream commit d8bf0c01642275c7dca1e5d02c34e4199c200b1f ]

The own OGM check is currently misplaced and can lead to the following
issues:

For one thing we might receive an aggregated OGM from a neighbor node
which has our own OGM in the first place. We would then not only skip
our own OGM but erroneously also any other, following OGM in the
aggregate.

For another, we might receive an OGM aggregate which has our own OGM in
a place other then the first one. Then we would wrongly not skip this
OGM, leading to populating the orginator and gateway table with ourself.

Fixes: 9323158ef9f4 ("batman-adv: OGMv2 - implement originators logic")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
net/batman-adv/bat_v_ogm.c