]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:22 +0000 (22:25 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 26 May 2021 13:39:08 +0000 (15:39 +0200)
commit5a94f3a425c05330c8d27178eda00e6b9945383d
treeb30e844214cfa58e23ff999c7ac848111e9e2736
parent3d14eba71739e7f45c499f53bdcbad7e1f935daf
ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family

BugLink: https://bugs.launchpad.net/bugs/1929615
[ Upstream commit 6503c568e97a52f8b7a3109718db438e52e59485 ]

The Maxim PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: eea6653aae7b ("ARM: dts: Enable PMIC interrupts for exynos4412-odroid-common")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-6-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
arch/arm/boot/dts/exynos4412-odroid-common.dtsi