]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drivers: net: fix memory leak in peak_usb_create_dev
authorPavel Skripkin <paskripkin@gmail.com>
Thu, 1 Apr 2021 13:27:52 +0000 (16:27 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 7 May 2021 07:53:46 +0000 (09:53 +0200)
commit5aa35b873bd716b9f85921aa894af2f35e0f4559
treefe38b6f6a6f30dc7e3607ff97fab45b3ab287f8d
parentb90b30783fe3244136fc5d92823f87c3e646e7b1
drivers: net: fix memory leak in peak_usb_create_dev

BugLink: https://bugs.launchpad.net/bugs/1926368
commit a0b96b4a62745397aee662670cfc2157bac03f55 upstream.

syzbot reported memory leak in peak_usb.
The problem was in case of failure after calling
->dev_init()[2] in peak_usb_create_dev()[1]. The data
allocated int dev_init() wasn't freed, so simple
->dev_free() call fix this problem.

backtrace:
    [<0000000079d6542a>] kmalloc include/linux/slab.h:552 [inline]
    [<0000000079d6542a>] kzalloc include/linux/slab.h:682 [inline]
    [<0000000079d6542a>] pcan_usb_fd_init+0x156/0x210 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:868   [2]
    [<00000000c09f9057>] peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:851 [inline] [1]
    [<00000000c09f9057>] peak_usb_probe+0x389/0x490 drivers/net/can/usb/peak_usb/pcan_usb_core.c:949

Reported-by: syzbot+91adee8d9ebb9193d22d@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/can/usb/peak_usb/pcan_usb_core.c