]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Drivers: hv: vmbus: Call hv_synic_free() if hv_synic_alloc() fails
authorDexuan Cui <decui@microsoft.com>
Thu, 4 May 2023 22:41:55 +0000 (15:41 -0700)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:19:18 +0000 (17:19 +0200)
commit5ac8cb23d39d4eabbd8feac0042bcb4407df25b0
tree5964bbc0250d3f46a19e67be8e708ae2ed994d1c
parent979e4028326139aabd75cd048800ac7030feb118
Drivers: hv: vmbus: Call hv_synic_free() if hv_synic_alloc() fails

BugLink: https://bugs.launchpad.net/bugs/2033931
commit ec97e112985c2581ee61854a4b74f080f6cdfc2c upstream.

Commit 572086325ce9 ("Drivers: hv: vmbus: Cleanup synic memory free path")
says "Any memory allocations that succeeded will be freed when the caller
cleans up by calling hv_synic_free()", but if the get_zeroed_page() in
hv_synic_alloc() fails, currently hv_synic_free() is not really called
in vmbus_bus_init(), consequently there will be a memory leak, e.g.
hv_context.hv_numa_map is not freed in the error path. Fix this by
updating the goto labels.

Cc: stable@kernel.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Fixes: 4df4cb9e99f8 ("x86/hyperv: Initialize clockevents earlier in CPU onlining")
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20230504224155.10484-1-decui@microsoft.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/hv/vmbus_drv.c