]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
media: dib9000: delete some unused broken code
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 26 Aug 2017 06:18:16 +0000 (02:18 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 12:46:42 +0000 (08:46 -0400)
commit5af478341fa3b2c35a7062ad80581751bf388977
tree20b17fca1433b4d25f1c562d869ce024e05ab047
parentcd3bef00c2528666c30a71c0cc9175721db9f9d1
media: dib9000: delete some unused broken code

The dib9000_remove_slave_frontend() function isn't used.

I was reviewing it because my static checker claims it writes one
element beyond the end of the array.  That's a false positive.  What it
actually does is, if there are two or more front ends, then it prints a
debug message to say that it removed the first one, stored in
state->fe[1], and then it "removes" (scare quotes on purpose) the second
one, stored in state->fe[2].  Deleting a front end from the middle is
not really supported and breaks code like dib9000_release() which
assumes the first NULL front end marks the end of the list.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/dib9000.c
drivers/media/dvb-frontends/dib9000.h