]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
spi: fsl-espi: avoid processing uninitalized data on error
authorArnd Bergmann <arnd@arndb.de>
Tue, 25 Oct 2016 20:57:10 +0000 (22:57 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 26 Oct 2016 10:14:52 +0000 (11:14 +0100)
commit5c0ba57744b1422d528f19430dd66d6803cea86f
treec0d2696dc0d1d5f68a783e7f84f4dc8e23864633
parent1001354ca34179f3db924eb66672442a173147dc
spi: fsl-espi: avoid processing uninitalized data on error

When we get a spurious interrupt in fsl_espi_irq, we end up
processing four uninitalized bytes of data, as shown in this
warning message:

   drivers/spi/spi-fsl-espi.c: In function 'fsl_espi_irq':
   drivers/spi/spi-fsl-espi.c:462:4: warning: 'rx_data' may be used uninitialized in this function [-Wmaybe-uninitialized]

This adds another check so we skip the data in this case.

Fixes: 6319a68011b8 ("spi/fsl-espi: avoid infinite loops on fsl_espi_cpu_irq()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
drivers/spi/spi-fsl-espi.c