]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ASoC: rt711-sdw: use first_hw_init flag on resume
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 7 Jun 2021 22:22:32 +0000 (17:22 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:23 +0000 (09:31 +0200)
commit5c50a946d1d3e3ecee0b1d5c975dd5d88c3d7b10
treee9acd7f261a7664b7959245afa0c51e2b71ce4b5
parent10f8b7943f6210dcd1525002598c869457d6f229
ASoC: rt711-sdw: use first_hw_init flag on resume

BugLink: https://bugs.launchpad.net/bugs/1938340
[ Upstream commit a0897ebca669f09a2e02206a9c48a738af655329 ]

The intent of the status check on resume was to verify if a SoundWire
peripheral reported ATTACHED before waiting for the initialization to
complete. This is required to avoid timeouts that will happen with
'ghost' devices that are exposed in the platform firmware but are not
populated in hardware.

Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to
another error, the resume operation never timed out, but the volume
settings were not properly restored.

BugLink: https://github.com/thesofproject/linux/issues/2908
BugLink: https://github.com/thesofproject/linux/issues/2637
Fixes: 320b8b0d13b81 ('ASoC: rt711: add rt711 codec driver')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
Link: https://lore.kernel.org/r/20210607222239.582139-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/codecs/rt711-sdw.c