]> git.proxmox.com Git - mirror_qemu.git/commit
xen: properly gate host writes of modified PCI CFG contents
authorJan Beulich <jbeulich@suse.com>
Tue, 2 Jun 2015 15:07:00 +0000 (15:07 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Tue, 2 Jun 2015 15:07:00 +0000 (15:07 +0000)
commit5c83b2f5b4b956e91dd6e5711f14df7ab800aefb
tree2ecb2b7bb863087b3288056ea312761dbc68a9c0
parent3fc827d591679f3e262b9d1f8b34528eabfca8c0
xen: properly gate host writes of modified PCI CFG contents

The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.

This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.

This is XSA-128.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen/xen_pt.c
hw/xen/xen_pt.h
hw/xen/xen_pt_config_init.c