]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nvme-pci: fix rapid add remove sequence
authorKeith Busch <keith.busch@intel.com>
Thu, 24 Jan 2019 01:46:11 +0000 (18:46 -0700)
committerChristoph Hellwig <hch@lst.de>
Wed, 6 Feb 2019 15:35:33 +0000 (16:35 +0100)
commit5c959d73dba6495ec01d04c206ee679d61ccb2b0
treed71d5b7665464c904c72b4715f1ba60bf7fdc0b6
parente7ad43c3eda6a1690c4c3c341f95dc1c6898da83
nvme-pci: fix rapid add remove sequence

A surprise removal may fail to tear down request queues if it is racing
with the initial asynchronous probe. If that happens, the remove path
won't see the queue resources to tear down, and the controller reset
path may create a new request queue on a removed device, but will not
be able to make forward progress, deadlocking the pci removal.

Protect setting up non-blocking resources from a shutdown by holding the
same mutex, and transition to the CONNECTING state after these resources
are initialized so the probe path may see the dead controller state
before dispatching new IO.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=202081
Reported-by: Alex Gagniuc <Alex_Gagniuc@Dellteam.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Tested-by: Alex Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c