]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
dmaengine: edma: fix memory leak when terminating running transfers
authorPetr Kulhavy <petr@barix.com>
Fri, 27 Mar 2015 11:35:51 +0000 (13:35 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 30 Mar 2015 17:47:08 +0000 (23:17 +0530)
commit5ca9e7ce6eebec53362ff779264143860ccf68cd
tree94ad7f41a22047616a192c241459b2090213adb1
parentca76683930a1c6acb8dd22867eca2bedaab998e3
dmaengine: edma: fix memory leak when terminating running transfers

If edma_terminate_all() was called while a transfer was running (i.e. after
edma_execute() but before edma_callback()) the echan->edesc was not freed.

This was due to the fact that a running transfer is on none of the
vchan lists: desc_submitted, desc_issued, desc_completed (edma_execute()
removes it from the desc_issued list), so the vchan_dma_desc_free_list()
called at the end of edma_terminate_all() didn't find it and didn't free it.

This bug was found on an AM1808 based hardware (very similar to da850evm,
however using the second MMC/SD controller), where intense operations on the SD
card wasted the device 128MB RAM within a couple of days.

Peter Ujfalusi:
The issue is even more severe since it affects cyclic (audio) transfers as
well. In this case starting/stopping audio will results memory leak.

Signed-off-by: Petr Kulhavy <petr@barix.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: <stable@vger.kernel.org>
CC: <linux-omap@vger.kernel.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/edma.c