]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
Input: palmas-pwrbutton - use IRQF_ONESHOT
authorNishanth Menon <nm@ti.com>
Mon, 15 Sep 2014 21:31:22 +0000 (14:31 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 15 Sep 2014 21:36:12 +0000 (14:36 -0700)
commit5cc19b7c5e71bdd1214813c6d65a1dd5b37807ac
treef040c321346ba3a61089ba5797fb912c257cb08f
parent3ace3686f198e656624d7ca2984d053e65f6e09d
Input: palmas-pwrbutton - use IRQF_ONESHOT

make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o
Reports:
drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Palmas power button just needs threaded IRQ handler since I2C operations
are involved and there is nothing in non-threaded primary handler we could
do.

So mark the request with ONESHOT as it should have been done in these
cases.

Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/palmas-pwrbutton.c