]> git.proxmox.com Git - mirror_qemu.git/commit
qapi: Simplify visits of optional fields
authorEric Blake <eblake@redhat.com>
Wed, 2 Dec 2015 05:20:52 +0000 (22:20 -0700)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 17 Dec 2015 07:21:29 +0000 (08:21 +0100)
commit5cdc8831a795fb8452d7e34f644202fd724e122a
treeed3741502d2d42dfda844d45beedf4307168eaad
parentd00341af384665d259af475b14c96bb8414df415
qapi: Simplify visits of optional fields

None of the visitor callbacks would set an error when testing
if an optional field was present; make this part of the interface
contract by eliminating the errp argument.

The resulting generated code has a nice diff:

|-    visit_optional(v, &has_fdset_id, "fdset-id", &err);
|-    if (err) {
|-        goto out;
|-    }
|+    visit_optional(v, &has_fdset_id, "fdset-id");
|     if (has_fdset_id) {
|         visit_type_int(v, &fdset_id, "fdset-id", &err);
|         if (err) {
|             goto out;
|         }
|     }

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1449033659-25497-9-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qapi/visitor-impl.h
include/qapi/visitor.h
qapi/opts-visitor.c
qapi/qapi-visit-core.c
qapi/qmp-input-visitor.c
qapi/string-input-visitor.c
scripts/qapi.py