]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
bonding: Use msecs_to_jiffies, eliminate panic
authorJay Vosburgh <fubar@us.ibm.com>
Sun, 18 May 2008 04:10:07 +0000 (21:10 -0700)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 22 May 2008 10:34:17 +0000 (06:34 -0400)
commit5ce0da8f0386b62345312ec8fed31303732f4220
tree001fb0e4f6b256f07851936f74d0805f931b63e8
parentd63ddcec20f59e78212aeaf5144e9652c0097211
bonding: Use msecs_to_jiffies, eliminate panic

Convert bonding to use msecs_to_jiffies instead of doing the
math.  For the ARP monitor, there was an underflow problem that could
result in an infinite loop.  The miimon already had that worked around,
but this is cleaner.

Originally by Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Jay Vosburgh corrected a math error in the original; Nicolas' original
commit message is:

When setting arp_interval parameter to a very low value, delta_in_ticks
for next arp might become 0, causing an infinite loop.

See http://bugzilla.kernel.org/show_bug.cgi?id=10680

Same problem for miimon parameter already fixed, but fix might be
enhanced, by using msecs_to_jiffies() function.

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/bonding/bond_main.c