]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
mac80211: use unaligned safe memcmp() in-place of compare_ether_addr()
authorShaddy Baddah <shaddy_baddah@hotmail.com>
Fri, 28 Nov 2008 06:08:10 +0000 (17:08 +1100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 5 Dec 2008 14:18:35 +0000 (09:18 -0500)
commit5cf12e8dc641ef028f0cf9c317a9567e6b794de1
tree79ab01689f1b81fd8a5e9a2c80b81387d19257b8
parentb8ddafd759e356c839774a8b87011b768deb53b3
mac80211: use unaligned safe memcmp() in-place of compare_ether_addr()

After fixing zd1211rw: use unaligned safe memcmp() in-place of
compare_ether_addr(), I started to see kernel log messages detailing
unaligned access:

  Kernel unaligned access at TPC[100f7f44] sta_info_get+0x24/0x68 [mac80211]

As with the aforementioned patch, the unaligned access was eminating
from a compare_ether_addr() call. Concerned that whilst it was safe to
assume that unalignment was the norm for the zd1211rw, and take
preventative measures, it may not be the case or acceptable to use the
easy fix of changing the call to memcmp().

My research however indicated that it was OK to do this, as there are
a few instances where memcmp() is the preferred mechanism for doing
mac address comparisons throughout the module.

Signed-off-by: Shaddy Baddah <shaddy_baddah@hotmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/sta_info.c