]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
amd-xgbe: Enable IRQs only if napi_complete_done() is true
authorLendacky, Thomas <Thomas.Lendacky@amd.com>
Thu, 9 Mar 2017 23:48:23 +0000 (17:48 -0600)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 22 Mar 2017 14:02:34 +0000 (08:02 -0600)
commit5cf2b81fa12054c55f65a483d40027501731e5ea
treea3fbd3619b082367df507f02e8d18d1fb7dc0ef9
parentdd296dd8663bcd43ec9958511579f6f922e14e8c
amd-xgbe: Enable IRQs only if napi_complete_done() is true

BugLink: http://bugs.launchpad.net/bugs/1675032
[ Upstream commit d7aba644ffdebf756e51e26a2229055211838e89 ]

Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync()
and enable_irq() when an interrupt is received to process Rx packets. If
the napi_complete_done() return value isn't checked an unbalanced enable
for the IRQ could result, generating a warning stack trace.

Update the driver to only enable interrupts if napi_complete_done() returns
true.

Reported-by: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/net/ethernet/amd/xgbe/xgbe-drv.c