]> git.proxmox.com Git - mirror_qemu.git/commit
block: forbid x-blockdev-del from acting on DriveInfo
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 31 Mar 2016 13:07:43 +0000 (15:07 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 5 Apr 2016 07:22:28 +0000 (09:22 +0200)
commit5cf87fd68e1ea06013594682cec6feb5488fb773
treebfcc7bfe741eb987702bcdebd52f976cc773ad89
parent2e3a76ae3e47d502f9f0c4424b719945fba9d459
block: forbid x-blockdev-del from acting on DriveInfo

Failing on -drive/drive_add created BlockBackends was a
requirement for x-blockdev-del, but it sneaked through
the patch review.  Let's fix it now.

Example:

$ x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=null-co://,id=null -qmp stdio
>> {'execute':'qmp_capabilities'}
<< {"return": {}}
>> {'execute':'x-blockdev-del','arguments':{'id':'null'}}
<< {"error": {"class": "GenericError", "desc": "Deleting block backend added with drive-add is not supported"}}

And without a DriveInfo:

>> { "execute": "blockdev-add", "arguments": { "options": { "driver":"null-co", "id":"null2"}}}
<< {"return": {}}
>> {'execute':'x-blockdev-del','arguments':{'id':'null2'}}
<< {"return": {}}

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
blockdev.c