]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
kernel/sysctl.c: add missing range check in do_proc_dointvec_minmax_conv
authorZev Weiss <zev@bewilderbeest.net>
Tue, 12 Mar 2019 06:28:02 +0000 (23:28 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit5d130ed00a9d2c4cca356b9b5c67f0fc8aa03ad0
tree338ca8a7e344320d36fc53482c62cea504d96de4
parent119cccddb28b0835734edfa48ed86bcced8263be
kernel/sysctl.c: add missing range check in do_proc_dointvec_minmax_conv

BugLink: https://bugs.launchpad.net/bugs/1837952
commit 8cf7630b29701d364f8df4a50e4f1f5e752b2778 upstream.

This bug has apparently existed since the introduction of this function
in the pre-git era (4500e91754d3 in Thomas Gleixner's history.git,
"[NET]: Add proc_dointvec_userhz_jiffies, use it for proper handling of
neighbour sysctls.").

As a minimal fix we can simply duplicate the corresponding check in
do_proc_dointvec_conv().

Link: http://lkml.kernel.org/r/20190207123426.9202-3-zev@bewilderbeest.net
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: Iurii Zaikin <yzaikin@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: <stable@vger.kernel.org> [2.6.2+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/sysctl.c