]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/vmw_vsock: fix NULL pointer dereference
authorNorbert Slusarek <nslusarek@gmx.net>
Fri, 5 Feb 2021 12:12:06 +0000 (13:12 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Feb 2021 23:03:17 +0000 (15:03 -0800)
commit5d1cbcc990f18edaddddef26677073c4e6fad7b7
treec7b2e72fa255c7080b07753bf70bbd4100b2f067
parentef66a1eace968ff22a35f45e6e8ec36b668b6116
net/vmw_vsock: fix NULL pointer dereference

In vsock_stream_connect(), a thread will enter schedule_timeout().
While being scheduled out, another thread can enter vsock_stream_connect()
as well and set vsk->transport to NULL. In case a signal was sent, the
first thread can leave schedule_timeout() and vsock_transport_cancel_pkt()
will be called right after. Inside vsock_transport_cancel_pkt(), a null
dereference will happen on transport->cancel_pkt.

Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
Signed-off-by: Norbert Slusarek <nslusarek@gmx.net>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/trinity-c2d6cede-bfb1-44e2-85af-1fbc7f541715-1612535117028@3c-app-gmx-bap12
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/vmw_vsock/af_vsock.c