]> git.proxmox.com Git - qemu.git/commit
qdev: Don't assume existence of parent bus on unparenting
authorAndreas Färber <afaerber@suse.de>
Fri, 4 Jan 2013 17:13:00 +0000 (18:13 +0100)
committerAndreas Färber <afaerber@suse.de>
Tue, 8 Jan 2013 20:03:43 +0000 (21:03 +0100)
commit5d5b24d042072fb4d13e7027f6e52e44390a9896
treeb7bf9690cbf8f55a88f2a78e12d176248a8b6c50
parent507066f8a9610c0088df19ce7b3e436f43165ec1
qdev: Don't assume existence of parent bus on unparenting

Commit 667d22d1ae59da46b4c1fbd094ca61145f19b8c3 (qdev: move bus removal
to object_unparent) made the assumption that at unparenting time
parent_bus is not NULL. This assumption is unjustified since
object_unparent() may well be called directly after object_initialize(),
without any qdev_set_parent_bus().

This did not cause any issues yet because qdev_[try_]create() does call
qdev_set_parent_bus(), falling back to SysBus if unsupplied.

While at it, ensure that this new function uses the device_ prefix and
make the name more neutral in light of this semantic change.

Reported-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Igor Mammedov <imammedo@redhat.com>
hw/qdev.c