]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Fix detection for a CMP-V PCH
authorImre Deak <imre.deak@intel.com>
Tue, 12 Nov 2019 10:46:08 +0000 (12:46 +0200)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 18 Nov 2019 14:36:03 +0000 (16:36 +0200)
commit5d77aa07bd2f4aa940c80a0d97471201b4a6a282
tree183dd74361839cec64b2e3050afb99103b0bf6da
parent36104fcf8ff4dd0b0ca8a79bc3fb5b1046deead2
drm/i915: Fix detection for a CMP-V PCH

According to internal documents I found for CMP PCHs the PCI ID 0xA3C1
belongs to a CMP-V chipset. Based on the same docs the programming of
the PCH is compatible with that of KBP. Fix up my previous wrong
assumption accordingly using the SPT programming which in turn is the
basis for KBP.

The original bug reporter verified that this is the correct PCH
identification (the only way we'll program valid DDC pin-pair values to
the GMBUS register) and the Windows team uses the same identification
(that is using the KBP programming model for this PCH).

I filed the necessary Bspec update requests (BSpec/33734).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112051
Fixes: 37c92dc303dd ("drm/i915: Add new CNL PCH ID seen on a CML platform")
Reported-and-tested-by: Cyrus <cyrus.lien@canonical.com>
Cc: Cyrus <cyrus.lien@canonical.com>
Cc: Timo Aaltonen <tjaalton@ubuntu.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191112104608.24587-1-imre.deak@intel.com
(cherry picked from commit 50a5065f4474c2dbc1f7462b45a32d33d7b48d88)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/intel_pch.c
drivers/gpu/drm/i915/intel_pch.h