]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/xe: Fix unreffed ptr leak on engine lookup
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Fri, 2 Jun 2023 17:27:32 +0000 (20:27 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:34:55 +0000 (11:34 -0500)
commit5db4afe1db56c10b6edef41ad9309bf0bed87f34
treee10e41b283dd6c49c5a381ffd830376cc6496dcc
parent898f86c23c600c8f70bf1a03e81a7be97038a72d
drm/xe: Fix unreffed ptr leak on engine lookup

The engine xarray holds a ref to engine, guarded by the lock.
While we do lookup for engine, we need to take the ref inside
the lock to prevent unreffed pointer escaping and
causing potential use-after-free after.

v2: remove branch prediction hint (Thomas)

Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230602172732.1001057-1-mika.kuoppala@linux.intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_engine.c