]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
media: media/saa7164: fix saa7164_encoder_register() memory leak bugs
authorDaniel Niv <danielniv3@gmail.com>
Thu, 11 Mar 2021 02:53:00 +0000 (03:53 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:32:08 +0000 (10:32 +0200)
commit5dbb529d08f9888d8d6a5792768c646f17938ad8
treebdb7a214284ab20390a39b2dfa2c3c21d7e5b335
parent14f4a70a6b32fbb8b3200a2fafce947ecf5d59ad
media: media/saa7164: fix saa7164_encoder_register() memory leak bugs

BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit c759b2970c561e3b56aa030deb13db104262adfe ]

Add a fix for the memory leak bugs that can occur when the
saa7164_encoder_register() function fails.
The function allocates memory without explicitly freeing
it when errors occur.
Add a better error handling that deallocate the unused buffers before the
function exits during a fail.

Signed-off-by: Daniel Niv <danielniv3@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/media/pci/saa7164/saa7164-encoder.c