]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
KVM: arm/arm64: vgic: fix possible spectre-v1 in vgic_mmio_read_apr()
authorMark Rutland <mark.rutland@arm.com>
Wed, 25 Apr 2018 16:13:42 +0000 (17:13 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 26 Apr 2018 16:06:00 +0000 (17:06 +0100)
commit5e1ca5e23b167987d5b6d8b08f2d5b7dd2d13f49
tree9a0111967f01a664c3be094fc9b0b895b1110cf6
parent41b87599c74300027f305d7b34368ec558978ff2
KVM: arm/arm64: vgic: fix possible spectre-v1 in vgic_mmio_read_apr()

It's possible for userspace to control n. Sanitize n when using it as an
array index.

Note that while it appears that n must be bound to the interval [0,3]
due to the way it is extracted from addr, we cannot guarantee that
compiler transformations (and/or future refactoring) will ensure this is
the case, and given this is a slow path it's better to always perform
the masking.

Found by smatch.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: kvmarm@lists.cs.columbia.edu
Signed-off-by: Will Deacon <will.deacon@arm.com>
virt/kvm/arm/vgic/vgic-mmio-v2.c