]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
can: rcar_can: fix IRQ check
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sat, 20 Jun 2015 00:32:46 +0000 (03:32 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 12 Jul 2015 18:57:41 +0000 (20:57 +0200)
commit5e63e6baa159fa8c787cf783dbf3d77fbea97331
tree8406c8f34f1abf9d89ec785a3d3c88df234fbb3e
parent2ee94014d9bd3868b1c0d17405f96d63bec83f28
can: rcar_can: fix IRQ check

rcar_can_probe() regards 0 as a wrong IRQ #, despite platform_get_irq() that it
calls returns negative error code in that case. This leads to the following
being printed to the console when attempting to open the device:

error requesting interrupt fffffffa

because  rcar_can_open() calls request_irq() with a negative IRQ #, and that
function naturally fails with -EINVAL.

Check for the negative error codes instead and propagate them upstream instead
of just returning -ENODEV.

Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar_can.c