]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: bcmgenet: Fix coalescing settings handling
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 28 Mar 2018 22:15:38 +0000 (15:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Mar 2018 14:03:36 +0000 (10:03 -0400)
commit5e6ce1f1a4ca83878f2966dd67afb39b631c4320
tree4b1ebeeac784369b3c7b9be808d0f72735fca711
parenta8cdfbdf885f3d3b4940ea31696a4492afd331f7
net: bcmgenet: Fix coalescing settings handling

There were a number of issues with setting the RX coalescing parameters:

- we would not be preserving values that would have been configured
  across close/open calls, instead we would always reset to no timeout
  and 1 interrupt per packet, this would also prevent DIM from setting its
  default usec/pkts values

- when adaptive RX would be turned on, we woud not be fetching the
  default parameters, we would stay with no timeout/1 packet per interrupt
  until the estimator kicks in and changes that

- finally disabling adaptive RX coalescing while providing parameters
  would not be honored, and we would stay with whatever DIM had previously
  determined instead of the user requested parameters

Fixes: 9f4ca05827a2 ("net: bcmgenet: Add support for adaptive RX coalescing")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Tal Gilboa <talgi@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c
drivers/net/ethernet/broadcom/genet/bcmgenet.h