]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ipv4: prevent potential spectre v1 gadget in fib_metrics_match()
authorEric Dumazet <edumazet@google.com>
Fri, 20 Jan 2023 13:31:40 +0000 (13:31 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Jan 2023 05:37:39 +0000 (21:37 -0800)
commit5e9398a26a92fc402d82ce1f97cc67d832527da0
tree306205c5751a295601e5889e5ae3fb9d0bb385eb
parent1d1d63b612801b3f0a39b7d4467cad0abd60e5c8
ipv4: prevent potential spectre v1 gadget in fib_metrics_match()

if (!type)
        continue;
    if (type > RTAX_MAX)
        return false;
    ...
    fi_val = fi->fib_metrics->metrics[type - 1];

@type being used as an array index, we need to prevent
cpu speculation or risk leaking kernel memory content.

Fixes: 5f9ae3d9e7e4 ("ipv4: do metrics match when looking up and deleting a route")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230120133140.3624204-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/fib_semantics.c