]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 19 Nov 2018 15:33:44 +0000 (10:33 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 11:42:15 +0000 (06:42 -0500)
commit5e99456c20f712dcc13d9f6ca4278937d5367355
treeb7df04e1962020806d52a64b14989139cb542110
parentd644cca50f366cd109845ae92e37c09ed79adf81
media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()

Userspace shouldn't set bytesused to 0 for output buffers.
vb2_warn_zero_bytesused() warns about this (only once!), but it also
calls WARN_ON(1), which is confusing since it is not immediately clear
that it warns about a 0 value for bytesused.

Just drop the WARN_ON as it serves no purpose.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/common/videobuf2/videobuf2-v4l2.c