]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
irqchip/atmel-aic: Fix potential deadlock in ->xlate()
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Tue, 13 Sep 2016 13:58:29 +0000 (15:58 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 13 Sep 2016 14:57:40 +0000 (16:57 +0200)
commit5eb0d6eb3fac3daa60d9190eed9fa41cf809c756
tree08d2a2d7653f2c8aa91947fef325065855502b2d
parentebf9ff753c041b296241990aef76163bbb2cc9c8
irqchip/atmel-aic: Fix potential deadlock in ->xlate()

aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip
lock without disabling interrupts, which can lead to a deadlock if an
interrupt occurs while the lock is held in one of these functions.

Replace irq_gc_{lock,unlock}() calls by
irq_gc_{lock_irqsave,unlock_irqrestore}() ones to prevent this bug from
happening.

Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Link: http://lkml.kernel.org/r/1473775109-4192-2-git-send-email-boris.brezillon@free-electrons.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-atmel-aic.c
drivers/irqchip/irq-atmel-aic5.c