]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xfs: limit superblock corruption errors to actual corruption
authorEric Sandeen <sandeen@redhat.com>
Wed, 19 Feb 2014 04:39:35 +0000 (15:39 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 19 Feb 2014 04:39:35 +0000 (15:39 +1100)
commit5ef11eb0700f806c4671ba33e5befa784a2f70ef
tree9746beb7ff88023b83ed8b1a42e2401bbaa0eaa1
parentdaba5427dad6b260256053f914de2c0b79f7a79f
xfs: limit superblock corruption errors to actual corruption

Today, if

xfs_sb_read_verify
  xfs_sb_verify
    xfs_mount_validate_sb

detects superblock corruption, it'll be extremely noisy, dumping
2 stacks, 2 hexdumps, etc.

This is because we call XFS_CORRUPTION_ERROR in xfs_mount_validate_sb
as well as in xfs_sb_read_verify.

Also, *any* errors in xfs_mount_validate_sb which are not corruption
per se; things like too-big-blocksize, bad version, bad magic, v1 dirs,
rw-incompat etc - things which do not return EFSCORRUPTED - will
still do the whole XFS_CORRUPTION_ERROR spew when xfs_sb_read_verify
sees any error at all.  And it suggests to the user that they
should run xfs_repair, even if the root cause of the mount failure
is a simple incompatibility.

I'll submit that the probably-not-corrupted errors don't warrant
this much noise, so this patch removes the warning for anything
other than EFSCORRUPTED returns, and replaces the lower-level
XFS_CORRUPTION_ERROR with an xfs_notice().

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_sb.c