]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
inet: fix improper empty comparison
authorJosef Bacik <jbacik@fb.com>
Mon, 16 Oct 2017 11:46:26 +0000 (13:46 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 19 Oct 2017 14:49:24 +0000 (09:49 -0500)
commit5f52f64d1387b9a658b47b87571a76587a1e7db7
tree843e8f8cddb23efd601ad511451eb948e5776947
parent27544477840bad2f5ea1ac0422afb8434227f978
inet: fix improper empty comparison

BugLink: http://bugs.launchpad.net/bugs/1722702
When doing my reuseport rework I screwed up and changed a

if (hlist_empty(&tb->owners))

to

if (!hlist_empty(&tb->owners))

This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind conflict if we
opened an ipv4 only socket on a port followed by an ipv6 only socket on
the same port.

Fixes: b9470c27607b ("inet: kill smallest_size and smallest_port")
Reported-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry-picked from commit fbed24bcc69d3e48c5402c371f19f5c7688871e5)
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
net/ipv4/inet_connection_sock.c