]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: samsung: Correct EINTG banks order
authorPaweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
Mon, 16 Apr 2018 15:52:45 +0000 (17:52 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 14 Jan 2019 09:28:55 +0000 (09:28 +0000)
commit5f5d747efae18340b8435e76ac1c782337bae719
treeccea8625f00b7e302f94d6b01995d8c7084af89a
parent470b655cf099f878495f89db86d01642fa5d6b6d
pinctrl: samsung: Correct EINTG banks order

BugLink: http://bugs.launchpad.net/bugs/1807469
commit 5cf9a338db94cfd570aa2607bef1b30996f188e3 upstream.

All banks with GPIO interrupts should be at beginning of bank array and
without any other types of banks between them.  This order is expected
by exynos_eint_gpio_irq, when doing interrupt group to bank translation.
Otherwise, kernel NULL pointer dereference would happen when trying to
handle interrupt, due to wrong bank being looked up.  Observed on
s5pv210, when trying to handle gpj0 interrupt, where kernel was mapping
it to gpi bank.

Cc: stable@vger.kernel.org
Fixes: 023e06dfa688 ("pinctrl: exynos: add exynos5410 SoC specific data")
Fixes: 608a26a7bc04 ("pinctrl: Add s5pv210 support to pinctrl-exynos)
Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/pinctrl/samsung/pinctrl-exynos-arm.c