]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
RDMA/ucma: Fix Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 16 Oct 2018 14:59:01 +0000 (16:59 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 24 Apr 2019 08:09:09 +0000 (10:09 +0200)
commit5f654aac63d4bcca64e1b35c206111f8153f2834
treed7999868e08e63fa0ec561207c05534ba453c9cd
parent9e689dfcce9fa468a5a45fb65b60c1bb87c05d65
RDMA/ucma: Fix Spectre v1 vulnerability

hdr.cmd can be indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

drivers/infiniband/core/ucma.c:1686 ucma_write() warn: potential
spectre issue 'ucma_cmd_table' [r] (local cap)

Fix this by sanitizing hdr.cmd before using it to index
ucm_cmd_table.

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
CVE-2017-5753

(cherry picked from commit a3671a4f973ee9d9621d60166cc3b037c397d604)
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/infiniband/core/ucma.c