]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: sonic: return NETDEV_TX_OK if failed to map buffer
authorMao Wenan <maowenan@huawei.com>
Thu, 5 Sep 2019 01:57:12 +0000 (09:57 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commit5fbfd6f0bbc38d335f8ea7fe277366b2cb95ce13
tree7913e183735af0531075a42bcb38a132ccbcfd4e
parent7cb9a44473714e45ef7d0133820271bdccf7a375
net: sonic: return NETDEV_TX_OK if failed to map buffer

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 6e1cdedcf0362fed3aedfe051d46bd7ee2a85fe1 ]

NETDEV_TX_BUSY really should only be used by drivers that call
netif_tx_stop_queue() at the wrong moment. If dma_map_single() is
failed to map tx DMA buffer, it might trigger an infinite loop.
This patch use NETDEV_TX_OK instead of NETDEV_TX_BUSY, and change
printk to pr_err_ratelimited.

Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/natsemi/sonic.c