]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/mediatek: avoid dereferencing a null hdmi_phy on an error message
authorColin Ian King <colin.king@canonical.com>
Mon, 7 Dec 2020 15:09:37 +0000 (15:09 +0000)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 4 Jan 2021 15:37:24 +0000 (16:37 +0100)
commit607dd4820006c65b7b3e043c9b50da3fd9cf2bc2
treeb4decdce8912b8cf711e876b597c6f240b3270be
parentd139bd49f72666d1b3e64da7ff13c768cc5d2684
drm/mediatek: avoid dereferencing a null hdmi_phy on an error message

BugLink: https://bugs.launchpad.net/bugs/1910111
[ Upstream commit b097efba9580d1f7cbc80cda84e768983e3de541 ]

Currently there is a null pointer check for hdmi_phy that implies it
may be null, however a dev_err messages dereferences this potential null
pointer.  Avoid a null pointer dereference by only emitting the dev_err
message if hdmi_phy is non-null.  It is a moot point if the error message
needs to be printed at all, but since this is a relatively new piece of
code it may be useful to keep the message in for the moment in case there
are unforseen errors that need to be reported.

Fixes: be28b6507c46 ("drm/mediatek: separate hdmi phy to different file")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Dereference after null check")
Link: https://lore.kernel.org/r/20201207150937.170435-1-colin.king@canonical.com
[vkoul: fix indent of return call]
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/phy/mediatek/phy-mtk-hdmi.c