]> git.proxmox.com Git - mirror_qemu.git/commit
hw/smbios: fix field corruption in type 4 table
authorJulia Suvorova <jusual@redhat.com>
Thu, 23 Feb 2023 12:57:47 +0000 (13:57 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 2 Mar 2023 08:10:46 +0000 (03:10 -0500)
commit60d09b8dc7dd4256d664ad680795cb1327805b2b
tree7af40f18872d3ffd226300e91d05c0b22ce66ad0
parent627634031092e1514f363fd8659a579398de0f0e
hw/smbios: fix field corruption in type 4 table

Since table type 4 of SMBIOS version 2.6 is shorter than 3.0, the
strings which follow immediately after the struct fields have been
overwritten by unconditional filling of later fields such as core_count2.
Make these fields dependent on the SMBIOS version.

Fixes: 05e27d74c7 ("hw/smbios: add core_count2 to smbios table type 4")
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2169904

Signed-off-by: Julia Suvorova <jusual@redhat.com>
Message-Id: <20230223125747.254914-1-jusual@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/smbios/smbios.c